Azure / azure-functions-durable-extension

Durable Task Framework extension for Azure Functions
MIT License
711 stars 263 forks source link

Add ActivityInputConverter #2708

Closed jviau closed 5 months ago

jviau commented 6 months ago

This PR adds an explicit ActivityInputConverter to work around the default Functions converter we were relying on. Specifically, the default converter special cases a few types (such as string) which we do not want. Adding this converter also has the added benefit of ensuring consistency between orchestrations and activity deserialization.

Another change is to register DurableTaskClientConverter directly on DurableClientAttribute via InputConverterAttribute (this was not available when we first wrote this converter).

Issue describing the changes in this PR

resolves #2674

Pull request checklist

davidmrdavid commented 6 months ago

@jviau: can we do a manual test to see if this is addressing this null-arg issue

jviau commented 6 months ago

@jviau Jacob Viau FTE: can we do a manual test to see if this is addressing this null-arg issue

Great point - tested it and made adjustments to handle this scenario.

prashantagrawalcrowe commented 5 months ago

Currently, I am using Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.0, so I wanted to ask in which version this issue would be resolved?