Closed jviau closed 5 months ago
@jviau: can we do a manual test to see if this is addressing this null-arg issue
@jviau Jacob Viau FTE: can we do a manual test to see if this is addressing this null-arg issue
Great point - tested it and made adjustments to handle this scenario.
Currently, I am using Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.0, so I wanted to ask in which version this issue would be resolved?
This PR adds an explicit
ActivityInputConverter
to work around the default Functions converter we were relying on. Specifically, the default converter special cases a few types (such as string) which we do not want. Adding this converter also has the added benefit of ensuring consistency between orchestrations and activity deserialization.Another change is to register
DurableTaskClientConverter
directly onDurableClientAttribute
viaInputConverterAttribute
(this was not available when we first wrote this converter).Issue describing the changes in this PR
resolves #2674
Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs