Azure / azure-functions-durable-extension

Durable Task Framework extension for Azure Functions
MIT License
713 stars 270 forks source link

[WIP] Re-add ScheduledStartTime to orchestration scheduling in .NET isolated #2805

Open davidmrdavid opened 5 months ago

davidmrdavid commented 5 months ago

Follow up to: https://github.com/Azure/azure-functions-durable-extension/pull/2634 https://github.com/Azure/azure-functions-durable-extension/pull/2544#issuecomment-1688579724

Fixes: https://github.com/microsoft/durabletask-dotnet/issues/256

When refactoring the localGrpcListener (used by .NET isolated and Java) to use an IDurableClient (necessary for Distributed Tracing), we accidentally dropped the ability to set an orchestrator's "fireAt" time. This PR adds that back.

Since the IDurableClient does not expose functionality for scheduled orchestrators, this PR constructs the TaskHubClient, which does expose that functionality. It also leaves a few "TODO" comments to simplify the implementation in the future.    Sitll pending:   Manual E2E test   Inclusion of distributed tracing regression test  * Inclusion of test of scheduled orchestrations test.  

Issue describing the changes in this PR

resolves https://github.com/microsoft/durabletask-dotnet/issues/256

Pull request checklist

developmentvegas commented 2 weeks ago

Hi, Is there any update on this? Several users are stuck trying to use the startAt and we can't ;(

davidmrdavid commented 1 week ago

This is missing some tests still unfortunately. Looking to get back to this soon, but have some urgent competing threads at the moment. If anyone is willing to contribute some tests in the meantime (described in the PR description), I'd be happy to incorporate them.