Seems we missed the TerminateInstanceAsync API in the PR above, so this PR adds it.
This PR also adds what appears to be the first set of unit tests for the .NET isolated worker extension. In it, we're testing against this particular exception: that the TerminateInstanceAsync API can be invoked without triggering exceptions. I tested with and without the code change and confirmed that the test is fails without the change, and passes with it.
Note: the new test project I added won't run as part of the CI automatically. I think to do that, I need to create a new ADO pipeline. Given that we're migrating our CI to a different ADO organization, now may not be the right time to add it either, so I'd like to do that in a different PR.
[x] My changes do not require documentation changes
[ ] Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
[ ] My changes should not be added to the release notes for the next release
[ ] Otherwise: I've added my notes to release_notes.md
[x] My changes do not need to be backported to a previous version
[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
[x] I have added all required tests (Unit tests, E2E tests)
[x] My changes do not require any extra work to be leveraged by OutOfProc SDKs
[ ] Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
[x] My changes do not change the version of the WebJobs.Extensions.DurableTask package
[ ] Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
[x] My changes do not add EventIds to our EventSource logs
[ ] Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
[x] My changes should be added to v3.x branch.
[ ] Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.
Follow up to: https://github.com/Azure/azure-functions-durable-extension/pull/2802
The PR above made the
FunctionsDurableTaskClientoverride new overloads fromDurableTaskClientwhich were causing issues as reported here: https://github.com/microsoft/durabletask-dotnet/issues/282#issuecomment-2114590648Seems we missed the
TerminateInstanceAsyncAPI in the PR above, so this PR adds it.This PR also adds what appears to be the first set of unit tests for the .NET isolated worker extension. In it, we're testing against this particular exception: that the
TerminateInstanceAsyncAPI can be invoked without triggering exceptions. I tested with and without the code change and confirmed that the test is fails without the change, and passes with it.Note: the new test project I added won't run as part of the CI automatically. I think to do that, I need to create a new ADO pipeline. Given that we're migrating our CI to a different ADO organization, now may not be the right time to add it either, so I'd like to do that in a different PR.
Issue describing the changes in this PR
resolves https://github.com/microsoft/durabletask-dotnet/issues/282#issuecomment-2114590648
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.cs