search

Azure / azure-functions-durable-extension

Durable Task Framework extension for Azure Functions
MIT License
711 stars 263 forks source link

Durable function orchestration won't failed immediately until all outstanding tasks finished #653

Open Gorden22 opened 5 years ago

Gorden22 commented 5 years ago

Describe the bug When one orchestration throw exception, durable function won't failed it immediately until all outstanding tasks finished or failed

cgillum commented 5 years ago

This is by design in the Durable Task Framework, as shown by the code here. Is the ask to change this behavior?

Gorden22 commented 5 years ago

This is by design in the Durable Task Framework, as shown by the code here. Is the ask to change this behavior?

Hi Chris, so we think this is kind of not make sense to us. If task need to set to completed, it make sense all in flights tasks need finished (faulted/completed/cancelled), but if in the code we want terminate the orchestration, we throw exception. But at same time, if some task still running, actually users not care about them this time, because if we want failed the workflow it means something wrong and orchestration should stop at this point, if tasks is very long, it may make the orchestration just stuck there. Is this a point make sense? Please advise

cgillum commented 5 years ago

Yes, I understand your point and I think it makes sense. We will need to check with the DTFx maintainers to see if they are okay with changing this behavior.