Azure / azure-functions-durable-js

JavaScript library for using the Durable Functions bindings
https://www.npmjs.com/package/durable-functions
MIT License
131 stars 48 forks source link

Compatibility with Durable Function Extension #379

Open eva-ortuno opened 2 years ago

eva-ortuno commented 2 years ago

When an activity function - called within a suborchestrator - throws an error, the durable calls coming after this failed call are not executed (callEntity, continueAsNew, callActivity, ...)

To reproduce the error, please check this repository : https://github.com/eva-ortuno/df-failed-activity-call

This seems to be due to the version of Microsoft.Azure.WebJobs.Extensions.DurableTask. The upgrade to version 2.6.0 was solving the issue.

Is that to be expected ? Should the ReadMe of durable-functions be updated to require this version of the extension ? Is there a compatibility issue with the extension ?

davidmrdavid commented 2 years ago

Hi @eva-ortuno, thanks for reaching out.

Yes, the Durable Functions SDK for NodeJS implicitly assumes that you're up to date with your Durable Functions Extension, and you're right that this should be documented more clearly in our README. Our apologies for the confusion. @hossam-nasr: could you please help me with a quick PR to our README to document this better?

Normally, most users don't have to worry about manually upgrading their Durable Exntesion version, as they utilize Extension Bundles to automatically get the latest packages. Is there a reason why you're manually managing your extension? That would help me understand how to improve the experience moving forward. Thanks!

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

hossam-nasr commented 1 year ago

Reactivating this issue to track README update/other relevant Docs to make sure this confusion doesn't happen again, as mentioned by @davidmrdavid