search

Azure / azure-functions-durable-js

JavaScript library for using the Durable Functions bindings
https://www.npmjs.com/package/durable-functions
MIT License
128 stars 47 forks source link

Fix suborchestrator input double serialization issue #440

Closed hossam-nasr closed 1 year ago

hossam-nasr commented 1 year ago

Fixes #436

davidmrdavid commented 1 year ago

@hossam-nasr: wouldn't this also affect the suborchestrator with-retry API? And what about entities?

hossam-nasr commented 1 year ago

@davidmrdavid Good call out! I tested the issue with context.df.callSubOrchestratorWithRetry() and context.df.callEntity() and found that it does reproduce, so I introduced the fix to the CallSubOrchestratorWithRetryAction and CallEntityAction too

hossam-nasr commented 1 year ago

@davidmrdavid SignalEntity doesn't seem to exist on v3.x 🤨 I think I branched v3.x out of v2.x before the signalEntity() addition was made. I will test this tho when I add it to this branch too, and I'll introduce the fix if it's required.