Azure / azure-functions-durable-js

JavaScript library for using the Durable Functions bindings
https://www.npmjs.com/package/durable-functions
MIT License
131 stars 47 forks source link

Rename `uri` to `url` everywhere in our public types/names #459

Closed hossam-nasr closed 1 year ago

hossam-nasr commented 1 year ago

As in title

hossam-nasr commented 1 year ago

Closing this issue. Besides CallHttpOptions, the only other types/interfaces that could be affected by this change would be:

All of these properties are named this way due to dependencies on the Durable extension. DurableHttpResponse describes the interface on the CallHttpAction that the extension expects, while HttpManagementPayload and HttpCreationPayload describe the interfaces of properties on the client data input binding value coming from the durable extension.

In all of these cases, we could still rename these properties to url, while adding logic to change the property names back to uri when sending to the extension and from uri coming from the extension, but such logic would be error-prone, and not worth it imo.

FYI @davidmrdavid @ejizba