Closed hossam-nasr closed 1 year ago
@hossam-nasr:
I'm curious to understand this scenario from your PR description a bit more:
""" Extension responds with valid response code, but some fields are missing (e.g., missing name property) """
Is this a valid response you've seen from the extension, or just a hypothetical scenario based on the previous implementation? If it's a response you've observed, what triggers it?
""" Extension responds with valid response code, but some fields are missing (e.g., missing name property) """
Is this a valid response you've seen from the extension, or just a hypothetical scenario based on the previous implementation? If it's a response you've observed, what triggers it?
This isn't a valid response and shouldn't be expected in regular behavior, but this is a safeguard I've added to protect us from similar situations as #486 just in case
Resolves #486 , see issue for more details. In addition to the issue outlined in #486, this PR also updates the behavior of
client.getStatus()
as follows:DurableOrchestrationStatus
object with timestamps asDate
objectsinstanceId
, extension responds with 404 and empty bodyname
property)In addition to these behavior changes, this PR also:
getStatus()
method to accurately represent what each status code means:instanceId
not foundTODO
flag ingetStatus()
unit tests, and replaces it with unit tests to test every response code, as aboveP.S.: This is a breaking change