search

Azure / azure-functions-durable-js

JavaScript library for using the Durable Functions bindings
https://www.npmjs.com/package/durable-functions
MIT License
129 stars 47 forks source link

Missing `.suspend` / `.resume` definitions in durableClient.d.ts #608

Open evanlouie opened 3 months ago

evanlouie commented 3 months ago

Describe the bug

Looks like suspend/resume support was landed in 3.1.0 (https://github.com/Azure/azure-functions-durable-js/pull/578) but durableClient.d.ts has not been updated to show the new methods.

Expected behavior

I should be able to see .suspend .resume on the DurableClient when coding in TypeScript

Actual behavior

Compiler cannot see .suspend and .resume because the d.ts file hasn't been updated.

evanlouie commented 3 months ago

Is there a reason why to use "declaration": false in the tsconfig.json? Seems like this sort of problem would be solved by having tsc automatically emit them and setting "types": "lib/src/index.d.ts" in package.json.

davidmrdavid commented 3 weeks ago

cc/ @erizba in case you have cycles.

@evanlouie I think we disabled tsc automatically emitting types to avoid the opposite problem: too many internally types being exposed, some by accident. In this case that's bitten us, but we've also been bit by the opposite behavior.