Azure / azure-functions-durable-powershell

PowerShell SDK for writing Durable Functions apps
MIT License
7 stars 3 forks source link

Patch terminate test #33

Closed davidmrdavid closed 1 year ago

davidmrdavid commented 1 year ago

This PR allows the "terminate test" to pass. 3 changes were needed: 1) Import System.Net in the .psm1 script so that [HttpStatusCode] may be recognized as a type 2) Have the Stop-Orchestration CmdLet use a POST request instead of GET 3) This was the tricky one: Ensure the orchestrator can take as input any type. Previously, it had int hardcoded as the input type. After changing it to object, the orchestrator executes correctly under this test. It appears we did not explicitly test passing inputs to orchestrators using the external SDK, and so we missed this. The execution of the orchestrator was unable to start as a result. We should consider ways of detecting this case in the future, although that might require explicit support from the C#-isolated SDK as the error is thrown at that level.