It includes 4 fixes:
1) In ValidateDurableWorkflowResults, it removes the assertion that when a DF Client returns an "Http OK" result, that the orchestrator has Completed. You may see evidence of this in the current SDK here
2) Renames Set-DurableCustomStatusExternal to Set-DurableCustomStatusE in DurablePatternsOrchestrator as that was causing that function to error out at the very end :)
3) To reduce flakiness, it adjusts the DurableClientTerminatesOrchestration to invoke a new function called "DurablePatternsOrchestratorWithExternalEvent" which, as its name implies, is the same as "DurablePatternsOrchestrator" except that at the very end it blocks in waiting for an external event. This should prevent the orchestrator from completing before the client gets a chance to send the terminate signal.
This PR should allow the Add remaining Durable cmdlets PR pass the CI tests.
It includes 4 fixes: 1) In
ValidateDurableWorkflowResults, it removes the assertion that when a DF Client returns an "Http OK" result, that the orchestrator has Completed. You may see evidence of this in the current SDK here2) Renames
Set-DurableCustomStatusExternaltoSet-DurableCustomStatusEin DurablePatternsOrchestrator as that was causing that function to error out at the very end :)3) To reduce flakiness, it adjusts the
DurableClientTerminatesOrchestrationto invoke a new function called "DurablePatternsOrchestratorWithExternalEvent" which, as its name implies, is the same as "DurablePatternsOrchestrator" except that at the very end it blocks in waiting for an external event. This should prevent the orchestrator from completing before the client gets a chance to send the terminate signal.4) It introduces a temporary hack to fix a recently found serialization issue. The issue is discussed here: https://github.com/Azure/azure-functions-durable-powershell-private/pull/34#discussion_r1154702741