search

Azure / azure-functions-durable-powershell

PowerShell SDK for writing Durable Functions apps
MIT License
7 stars 3 forks source link

Patch externalevent and InstanceId e2e test #40

Closed davidmrdavid closed 1 year ago

davidmrdavid commented 1 year ago

This PR should address 2/3 of the failing E2E tests in https://github.com/Azure/azure-functions-durable-powershell-private/pull/39.

It includes 2 fixes:

  1. It appears we were ignoring the $InstanceId param in Start-DurableOrchestrationExternal. This is not happening in the worker, so we probably introduced that bug early on (not sure why) and forgot to revert it.
  2. In the "BasicExternalOrchestrator" test, we have added multiple activity invocations around the external event. These are writing to the output buffer, which changes the result of the orchestration. I believe this is consistent with the current SDK's behavior. Therefore, the fix is to either save the output of the invokeActivities to variables (so they get captured before they enter the output buffer) or to not have those activity invocations at all. I went for the latter approach, but I'm ok with either.

~Update: seems the external event test is failing still (though the instanceID test is passing). Debugging that right now~