search

Azure / azure-functions-eventgrid-extension

EventGrid extension for Azure Functions
MIT License
48 stars 32 forks source link

CloudEvent schema not working for EventGridTrigger #111

Closed sandromastronardi closed 1 year ago

sandromastronardi commented 1 year ago

I seem to be missing the CloudEvent deserialisation here

https://github.com/Azure/azure-functions-eventgrid-extension/blob/3a2c7666b4f4c0eb4995e0250bca26d04f448208/src/EventGridExtension/EventGridExtensionConfigProvider.cs#L71

The docs say i can use CloudEvents but in reality i cannot, the validation of the endpoint fails. https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/README.md

Did some code disappear? How should it work? I'm using a webhook now, but for those the 401's cause a drop of messages so i want to use the builtin feature.

Sandro

sandromastronardi commented 1 year ago

never mind, this seems to be old code, i found this: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/src/TriggerBinding/HttpRequestProcessor.cs

and it seems the version wasnt the latest one even though i thought it was (the beta didnt' show in the nuget manager dropdown and so the last version was shown) . my bad...