search

Azure / azure-functions-eventgrid-extension

EventGrid extension for Azure Functions
MIT License
48 stars 32 forks source link

improve property xml comments #83

Closed brandonh-msft closed 10 hours ago

brandonh-msft commented 4 years ago

In response to an internal thread, this improves the XML comments around TopicEndpointUri of the output binding to direct users that it's an app setting key which should go as the value here, not the actual URI or the %% nomenclature

brandonh-msft commented 4 years ago

@brettsam any chance you have some time to pull this in?

brettsam commented 4 years ago

I'm not really the expert on eventgrid but let me see if I can find the right person. @ankitkumarr I see you made some commits -- are you the expert here?

ankitkumarr commented 4 years ago

Not the expert, but I did work on this a bit. I think we'd have to verify the impact of the major version update.

Maybe @brandonh-msft, as you suggested, we can remove the bump for now. And take that separately if we want to.

brandonh-msft commented 4 years ago

k, rolled the nuget-updating commit back.

brandonh-msft commented 4 years ago

lol @brettsam needs to whip out the Amex ;)

image

brettsam commented 4 years ago

Umm... yeah really! I'll look into that!

brandonh-msft commented 4 years ago

what's the best way to try re-running the build? Just push a no-op commit?

brandonh-msft commented 4 years ago

ah, there we go. @ankitkumarr , @brettsam

brandonh-msft commented 4 years ago

@alrod can you pull this in?