Azure / azure-functions-host

The host/runtime that powers Azure Functions
https://functions.azure.com
MIT License
1.92k stars 442 forks source link

Configuration set by the CLI is being ovveridden #2894

Open pragnagopa opened 6 years ago

pragnagopa commented 6 years ago

Azure Functions CLI sets commandline arguments for configuring language worker debug ports: StartHostAction.cs#L157 But this config is being ovverridden in the functions script settings manager ScriptSettingsManager.cs#L128

This is breaking debug experience in VSCode: https://github.com/Microsoft/vscode-azurefunctions/issues/387

pragnagopa commented 6 years ago

To fix the debug experience, we have decided to update CLI to inject language worker debug settings as environment variables instead of commanline arguments.

brettsam commented 6 years ago

Need to validate that our upcoming DI changes address this.

fabiocav commented 6 years ago

Can we validate this now that our DI changes have been completed?

fabiocav commented 5 years ago

@pragnagopa is this still an issue?