search

Azure / azure-functions-java-library

Contains annotations for writing Azure Functions in Java
MIT License
43 stars 43 forks source link

Rename HttpWebHookType to WebHookType #17

Closed pragnagopa closed 6 years ago

pragnagopa commented 6 years ago

Rename HttpWebHookType to WebHookType to match function.json property binding-expressions---json-payloads

brunoborges commented 6 years ago

Are webhooks used with other triggers as well?

pragnagopa commented 6 years ago

webHook is a http callback and specific to httpTriggers.

pragnagopa commented 6 years ago

Since a webhook by definition is a http call back, appending http to the name feels redundant

brunoborges commented 6 years ago

It helps users quickly understand the purpose of the class without even needing to read the javadoc. All Http related classes and interfaces start with Http too, so there's that. But anyways, it is up to you. :-) I'm fine either way.

pragnagopa commented 6 years ago

renaming in favor of consistency across languages :)