Azure / azure-functions-java-library

Contains annotations for writing Azure Functions in Java

MIT License

43 stars 43 forks source link

Add remaining samples P1 bindings/triggers #40

Closed JunyiYi closed 5 years ago

JunyiYi commented 6 years ago

Remarks The verified bindings and triggers are added in #38 . In this PR, we will focus on the following content.

Not tested

EventGridTrigger: Requires deployment to Azure, not testable locally.

Related issues

34 , #36 .

rloutlaw commented 6 years ago

I just looked at the Cosmos DB Output example again. Can you test this function to make sure it matches the description in the JavaDocs? They code I'm reading and the text in the description seem to do two different things, if this isn't the case is there a more clear/concise way to construct the sample so that the intent of the code is clear?

JunyiYi commented 6 years ago

Sure @rloutlaw . But the CosmosDB related bindings are failing in the production environment. And we have no ETA for that. #Closed

JunyiYi commented 6 years ago

Hi @rloutlaw , I have updated the code according to your suggestion, please take a look. Thanks. #Closed

pragnagopa commented 5 years ago

@JunyiYi - Can you please verify with the latest bits? I will merge this in one you confirm.

pragnagopa commented 5 years ago

@JunyiYi - Can you either update the PR or close this? If you do not have cycles, please close this. I will test and add these samples myself

JunyiYi commented 5 years ago

Hi @pragnagopa , the CosmosDB samples are modified and verified with the latest runtime. So you don't need to create your own version :)

But I'm still not sure how to use the EventGrid, so would you please try to copy the code and verify the EventGrid one?