Committing changes required to have Azure Functions depend on the centralized Microsoft BOM file for Java libraries

Azure / azure-functions-java-library

Contains annotations for writing Azure Functions in Java

MIT License

43 stars 43 forks source link

Committing changes required to have Azure Functions depend on the centralized Microsoft BOM file for Java libraries #52

Closed JonathanGiles closed 6 years ago

JonathanGiles commented 6 years ago

As discussed via email. There should be no need to introduce version dependencies into this POM any longer, instead depending on the com.microsoft.maven parent pom instead. Please feel free to share any concerns, questions, or anything else - I am happy to answer them and ensure you're comfortable before (and if) you accept this pull request.

pragnagopa commented 6 years ago

Is there a way for the CI to consume the snapshot plugin?
Can you please add link to the repo for java-8-parent?

JonathanGiles commented 6 years ago

Repo is here: https://github.com/Microsoft/maven-java-parent

Apologies about the build break - I tested locally where the snapshots were already installed. I've updated this PR.

pragnagopa commented 6 years ago

PR build still failing. Is the snapshot version available on maven central? If not probably maven settings file should include some info about where to find it Also, I am trying to figure out testing process for pulling the changes in Library to azure-functions-java-worker. Is it a good practice to publish snapshot version to maven central? Or should we test from so sonatype

JonathanGiles commented 6 years ago

The PR build never run after I updated the commit, but I did test and it appears to run fine.

pragnagopa commented 6 years ago

@JonathanGiles - PR did build with the latest changes but still failing. I will look into it. I can build these changes locally.

pragnagopa commented 6 years ago

We have a green build!