search

Azure / azure-functions-java-library

Contains annotations for writing Azure Functions in Java
MIT License
43 stars 43 forks source link

Add SignalR Service annotations and classes #78

Closed anthonychu closed 5 years ago

anthonychu commented 5 years ago

Add annotations and classes to support Azure SignalR bindings.

pragnagopa commented 5 years ago

Thanks @anthonychu. Will discuss with @fabiocav if azure-functions-java-library is the right place to add annotations added/supported by the partner teams.

bradygaster commented 5 years ago

also curious what @fabiocav thinks about this - keep me posted.

pragnagopa commented 5 years ago

cc @asavaritayal @jeffhollan As this new annotation is a kind of custom binding, it should take advantage of custom binding annotation:

import com.microsoft.azure.functions.annotation.CustomBinding;

@Target(ElementType.PARAMETER)
@Retention(RetentionPolicy.RUNTIME)
@CustomBinding(direction = "in", name = "", type = "customBinding")
public @interface TestCustomBinding {
   String index();
   String path();
   String name();
}

Also, please move this code to separate repo and publish a separate library. Naming convention azure-functions-java-library-signalr ? This would be easier to maintain as releases do not have to tie with azure functions. Also, maven plugin does not have to be updated for signalr as it is going to support CustomBinding soon.

pragnagopa commented 5 years ago

@Flanker32 @jdneo

pragnagopa commented 5 years ago

Closing this PR in favor of https://github.com/Azure/azure-functions-signalrservice-extension/pull/48 cc @JialinXin