search

Azure / azure-functions-openai-extension

An extension that adds support for Azure OpenAI/ OpenAI bindings in Azure Functions for LLM (GPT-3.5-Turbo, GPT-4, etc)
MIT License
79 stars 29 forks source link

Add nuget packaging build #5

Closed manvkaur closed 11 months ago

manvkaur commented 11 months ago
cgillum commented 11 months ago

Warning CS7035: The specified version string '0.5.0.158770' does not conform to the recommended format - major.minor.build.revision

Where is this warning coming from? I assume the problem is 158770, which I also assume comes from $(Build.BuildId)? And is it the azfunc ADO instance which is running these builds? We may need to remove the -p:FileVersionRevision=$(Build.BuildId) argument if the azfunc ADO instance build IDs are too large.

10361608 root cause package - Microsoft.Azure.WebJobs.Extensions.DurableTask doesn't have the fix in latest rc package for Azure Identity

Please follow up with @davidmrdavid for issues related to the Durable Functions extension.

10361610 - root cause - MVC Core package used in sample is deprecated, no more updates available

If I'm reading this correctly, the problem is with Newtonsoft.Json, not the MVC Core package. Try adding an explicit reference to the latest Newtonsoft.Json package versions to the flagged projects.

manvkaur commented 11 months ago

Warning CS7035: The specified version string '0.5.0.158770' does not conform to the recommended format - major.minor.build.revision

Where is this warning coming from? I assume the problem is 158770, which I also assume comes from $(Build.BuildId)? And is it the azfunc ADO instance which is running these builds? We may need to remove the -p:FileVersionRevision=$(Build.BuildId) argument if the azfunc ADO instance build IDs are too large.

It is coming from roslyn analyser as part of dotnet build task - https://dev.azure.com/azfunc/Azure%20Functions/_build/results?buildId=158792&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=006e6f7c-8314-5e02-a3df-483f3a1f4cfa&l=14 does that mean we remove the file version altogether or we can ignore the warning?

For

10361608 root cause package - Microsoft.Azure.WebJobs.Extensions.DurableTask doesn't have the fix in latest rc package for Azure Identity

Please follow up with @davidmrdavid for issues related to the Durable Functions extension.

I have added an explicit reference to Azure.Identity and Newtonsoft.Json for the other alert @cgillum

cgillum commented 11 months ago

It is coming from roslyn analyser as part of dotnet build task

I see that this number comes from this part of the dotnet build: -p:FileVersionRevision=158792, so it is indeed the $(Build.BuildId) value.

does that mean we remove the file version altogether or we can ignore the warning?

We shouldn't have any build warnings, so we should either suppress the warning, find another way to generate a file revision number, or don't specify a file revision number at all (which is also an acceptable option since it's not especially important).

manvkaur commented 11 months ago

It is coming from roslyn analyser as part of dotnet build task

I see that this number comes from this part of the dotnet build: -p:FileVersionRevision=158792, so it is indeed the $(Build.BuildId) value.

does that mean we remove the file version altogether or we can ignore the warning?

We shouldn't have any build warnings, so we should either suppress the warning, find another way to generate a file revision number, or don't specify a file revision number at all (which is also an acceptable option since it's not especially important).

Yes, it is coming from build Id and max supported value is 16 bit. I am removing it for now.