search

Azure / azure-functions-python-library

Azure Functions Python SDK
MIT License
151 stars 63 forks source link

remove internal cosmosdb keys filtering #119

Closed YunchuWang closed 2 years ago

YunchuWang commented 2 years ago

Change to address BUG: Cosmos DB Document should not be filtering _ts address https://github.com/Azure/azure-functions-python-library/issues/120

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (43600c0) into dev (d0d3f8f) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #119      +/-   ##
==========================================
- Coverage   84.66%   84.65%   -0.02%     
==========================================
  Files          46       46              
  Lines        2719     2717       -2     
  Branches      363      363              
==========================================
- Hits         2302     2300       -2     
  Misses        343      343              
  Partials       74       74
Flag Coverage Δ
unittests 84.65% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/_cosmosdb.py 88.88% <100.00%> (-1.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0d3f8f...43600c0. Read the comment docs.

gavin-aguiar commented 2 years ago

We should add one of the removed syskeys like etag to one of the existing tests in test_cosmosdb and check if len(doc.items) matches the data. That should take care of the code coverage tests.