Closed davidmrdavid closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4b6c9eb
) 93.09% compared to head (c338f9a
) 93.09%.:exclamation: Current head c338f9a differs from pull request most recent head 39f3a57. Consider uploading reports for the commit 39f3a57 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi David @davidmrdavid , wonder what error customer has seen from this breaking change? and is this starting to happen just recently?
@gavin-aguiar: I noticed the tests are failing, any ideas on what happened?
This PR (https://github.com/Azure/azure-functions-python-library/pulls?q=is%3Apr+is%3Aclosed+settingsapi) seems to have made a breaking change prevent DF BluePrints from using the
function_name
decorator in versions < 1.2.8 ofazure-functions-durable
.This PR mitigates that breaking change by creating a backwards compatibility layer that allows anything that inherits from
TriggerAPI
to continue usingfunction_name
. I also keep the implementation ofSettingsApi
'sfunction_name
to be the same as thisTriggerAPI
backwards compat layer by unifying the implementations under a_function_name
private method inherited fromDecoratorAPI
. The approach isn't perfect, but I think it's sufficiently clean given the circumstances.I also added a test to validate this worked