search

Azure / azure-functions-python-library

Azure Functions Python SDK
MIT License
151 stars 63 forks source link

Expose the trace context from the worker #93

Closed allenhumphreys closed 2 years ago

allenhumphreys commented 3 years ago

As best I can tell, this update will simply allow typed/known access to values that already exist but aren't yet exposed.

Having access to these values is very helpful for tracing instrumentation.

References: https://github.com/Azure/azure-functions-python-worker/blob/main/azure_functions_worker/bindings/context.py https://github.com/Azure/azure-functions-python-worker/blob/698c524db03b70b13fb42d17e7b986ea8f744b6d/azure_functions_worker/bindings/tracecontext.py https://github.com/Azure/azure-functions-python-worker/pull/545/files#diff-4b26101cf19d671ade506a5f9623a651bd389240b020b6176061abca184b2b6e

Screen Shot 2021-06-24 at 11 42 00 AM
ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

allenhumphreys commented 2 years ago

@vrdmr @AnatoliB Anything I can do to move this forward?

allenhumphreys commented 2 years ago

This effort seems to have been duplicated by @gavin-aguiar some 4 months later on #96

If you don't accept PRs from the public, you should probably turn that off.

stefanushinardi commented 2 years ago

Hello @allenhumphreys, we apologize for the miss on our side. It wasn't our intention to not merge your PR. Hazhzeng left the team and some of the context was missed during the transition.

allenhumphreys commented 2 years ago

@stefanushinardi thanks you for the apology and explanation 🙏🏼. Knowledge transfer can be super tricky!

Glad to have these properties fully support either way!