Azure / azure-functions-python-worker

Python worker for Azure Functions.
http://aka.ms/azurefunctions
MIT License
335 stars 103 forks source link

[DNM] Release/test mac m1 #1146

Closed vrdmr closed 1 year ago

vrdmr commented 1 year ago

Description

Fixes #


PR information

Quality of Code and Contribution Guidelines

codecov[bot] commented 1 year ago

Codecov Report

Merging #1146 (1b7fc21) into dev (832d261) will decrease coverage by 53.61%. The diff coverage is n/a.

:exclamation: Current head 1b7fc21 differs from pull request most recent head 1d3bc48. Consider uploading reports for the commit 1d3bc48 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1146       +/-   ##
===========================================
- Coverage   84.92%   31.30%   -53.62%     
===========================================
  Files          32       32               
  Lines        1824     1824               
  Branches      276      276               
===========================================
- Hits         1549      571      -978     
- Misses        204     1252     +1048     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.30% <ø> (-53.57%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) :arrow_down:
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) :arrow_down:
azure_functions_worker/dispatcher.py 19.17% <0.00%> (-69.69%) :arrow_down:
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) :arrow_down:
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) :arrow_down:
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) :arrow_down:
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) :arrow_down:
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) :arrow_down:
azure_functions_worker/extension.py 44.95% <0.00%> (-54.13%) :arrow_down:
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) :arrow_down:
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sxmanton commented 1 year ago

Just wanted to link issue #915 to so anyone finding that issue can see that this has been worked on. Although it seems there's been no activity on the PR for a couple months now. May I inquire if there is any ETA for this fix? Or anything I might be able to do to help?

jschwendt commented 1 year ago

@vrdmr Thank you for putting up this PR! Would love to see this get updated and merged. Let us know if we can help in some way as we're blocked without it.

vrdmr commented 1 year ago

Closing in favor of #1267. Apologies for the delay on this.