Azure / azure-functions-python-worker

Python worker for Azure Functions.
http://aka.ms/azurefunctions
MIT License
334 stars 103 forks source link

BYOC BYOF documentation and portal issues #138

Closed priyaananthasankar closed 6 years ago

priyaananthasankar commented 6 years ago

Bring Your Own Container (BYOC) This scenario is completely broken for Azure as of last week. You can run everything locally, but actually referencing a Docker image in Azure does not work. Debugging is very difficult and is not well documented. It is super confusing to determine which base image should be used (latest, v2.0.11651-alpha, 2.0.0-jessie, dev-nightly). They reference multiple different images in their tools and some versions are unstable. The Azure portal Functions App selection is very confusing between Linux and Docker options, because both allow you to specify the docker container (2 screenshots):

I find that between these two docs, it is unclear how they map to what is being created through the Azure Portal:

https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-first-azure-function-azure-cli-linux (This appears to create a Docker functions App)

https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-function-linux-custom-image (This appears to create a Linux functions App)

Debugging experience in Azure is very poor, the logs in the above screenshot are not complete (Maybe they cut off after a certain number of lines?)

(minor) The UI that allows you to set the container image is buggy, after you set it sometimes you see the old image name and have to refresh.

(minor) It is recommend to store secrets in the Application Settings, but all of the secret values are visible in the Portal in plaintext.

asavaritayal commented 6 years ago

Breaking this down -

Bring Your Own Container (BYOC) This scenario is completely broken for Azure as of last week. You can run everything locally, but actually referencing a Docker image in Azure does not work. Debugging is very difficult and is not well documented.

This is a runtime regression - https://github.com/Azure/azure-functions-host/pull/2917. Fix available here (yet to be released) - https://github.com/Azure/azure-functions-docker-python-sample/pull/18#pullrequestreview-125492965

It is super confusing to determine which base image should be used (latest, v2.0.11651-alpha, 2.0.0-jessie, dev-nightly). They reference multiple different images in their tools and some versions are unstable.

We only recommend using the builds referenced in our documentation.

The Azure portal Functions App selection is very confusing between Linux and Docker options, because both allow you to specify the docker container (2 screenshots): I find that between these two docs, it is unclear how they map to what is being created through the Azure Portal: https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-first-azure-function-azure-cli-linux (This appears to create a Docker functions App) https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-function-linux-custom-image (This appears to create a Linux functions App)

Link 1 is bring-your-own-files. Link 2 is bring-your-custom-image. The docker option in BYOF is a feature of App Service. The option will disappear once the consumption offering is available. /cc @dariagrigoriu

Debugging experience in Azure is very poor, the logs in the above screenshot are not complete (Maybe they cut off after a certain number of lines?)

Can you please attach the screenshot? /cc @pragnagopa

(minor) The UI that allows you to set the container image is buggy, after you set it sometimes you see the old image name and have to refresh.

@dariagrigoriu , @Jen7714 as this is a Linux issue.

(minor) It is recommend to store secrets in the Application Settings, but all of the secret values are visible in the Portal in plaintext.

The Key Vault integration is on the UX backlog for Functions. /cc @mattchenderson

asavaritayal commented 6 years ago

No action required at this time. @priyaananthasankar RE: the logging issue -

Debugging experience in Azure is very poor, the logs in the above screenshot are not complete (Maybe they cut off after a certain number of lines?)

Let us know if you have a screenshot of the logs being cut off so we can investigate further. Closing the current issue for now.