Azure / azure-functions-python-worker

Python worker for Azure Functions.
http://aka.ms/azurefunctions
MIT License
335 stars 103 forks source link

[Bug] ASGIFunctionApp - scope.state from lifespan startup is not delivered in subsequent request.state #1566

Open ashleysommer opened 3 weeks ago

ashleysommer commented 3 weeks ago

Expected Behavior

The ASGI Spec states that contents of the lifespan startup's scope.state dict is stored by the ASGI server, and the state is added to any subsequent ASGI Requests. https://asgi.readthedocs.io/en/latest/specs/lifespan.html

Applications often want to persist data from the lifespan cycle to request/response handling. ... The server will ensure that a shallow copy of the namespace is passed into each subsequent request/response call into the application.

Actual Behavior

When a lifespan startup handler adds content to the scope.state dict, it is correctly stored in the ASGIMiddleware state property, however the state is never used again, it is not added to request.state in subsequent ASGI Requests as expected.

Steps to Reproduce

1) Create an ASGI App that supports ASGI Lifetime handling (eg, Starlette, or FastAPI) 2) Create a Lifetime handler, that receives the Scope object 3) Add some content to the Scope.state dict,

Where are you facing this problem?

Local - Core Tools

ashleysommer commented 3 weeks ago

I've created a PR to fix this now, on the azure-functions repo: https://github.com/Azure/azure-functions-python-library/pull/240