search

Azure / azure-functions-servicebus-extension

Service Bus extension for Azure Functions
MIT License
65 stars 35 forks source link

Introducing function level auto complete for single/batch and sessions #141

Open apranaseth opened 3 years ago

apranaseth commented 3 years ago

https://github.com/Azure/azure-functions-servicebus-extension/issues/138

alrod commented 3 years ago

Also we need to validate new setting works with function.json and update docs in https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-service-bus-trigger?tabs=csharp#configuration

alrod commented 3 years ago

Overall the change looks good to me. The only concerns are tests:

  1. We do not need to test drain mode Drain mode/Sessions in E2E tests with the change. I would add one new E2E test to test that AutoComplete is overwritten.
  2. Add a unit tests for ServiceBusOptions.DeepClone - to make sure all properties are copied.
    • maybe add a unit test for ServiceBusTriggerAttribute.TryCreateAsync/GetServiceBusOptions (or modify existing)- to make sure the overwrite is applied.
apranaseth commented 3 years ago

I have removed all E2E but one to test it E2E and have added the unit tests.