search

Azure / azure-functions-vs-build-sdk

MSBuild task for Azure Functions
MIT License
95 stars 64 forks source link

Fixed issue with functions in nested classes not being found #526

Open woojamon opened 2 years ago

woojamon commented 2 years ago

Should fix #401, but also fixes an issue I was having with defining functions inside nested classes, where the runtime wouldn't discover them.

I couldn't run most of the tests in the solution for some reason, but I was able to run the relevant NestedFunctionMethodsAreExported and FunctionMethodsAreExported tests to verify new functionality according to red/green testing.

The only difference in the tests is the NestedFunctionsClass in test/Microsoft.NET.Sdk.Functions.Generator.Tests/FunctionJsonConverterTests.cs, line: 112

112: var functions = converter.GenerateFunctions(new[] { TestUtility.GetTypeDefinition(typeof(NestedFunctionsClass)) });
net-foundation-cla[bot] commented 2 years ago

CLA assistant check
All CLA requirements met.

woojamon commented 2 years ago

Looks like the build failed due to some issue with trying to access an azure storage account. Unfortunately I'm not sure if I can fix that. Tests passed though :)