search

Azure / azure-functions-vs-build-sdk

MSBuild task for Azure Functions
MIT License
95 stars 64 forks source link

Include all bindings when generating function metadata #542

Closed kshyju closed 2 years ago

kshyju commented 2 years ago

Currently, when a function invocation happens, we log binding usage to our function metrics logs table. We recently found out that not all the bindings were logged for in-proc precompiled apps.

For in-proc apps, the function.json generated is not including all the bindings. It is including only the trigger bindings. In this PR, we are making a change to include all bindings.

We have also decided to remove the binding direction from the event name when logging the binding metric in host.

net-foundation-cla[bot] commented 2 years ago

CLA assistant check
All CLA requirements met.

mathewc commented 2 years ago

Looks like you have some build failures, but code looks good to me

kshyju commented 2 years ago

Looks like you have some build failures, but code looks good to me

Build failure is caused by an unrelated issue. I have another PR to fix it here. https://github.com/Azure/azure-functions-vs-build-sdk/pull/543 Will rebase this branch after that one is merged.

kshyju commented 2 years ago

Sdk.Functions package 4.1.0 which has this fix, is now available in nuget gallery.

https://www.nuget.org/packages/Microsoft.NET.Sdk.Functions/4.1.0