search

Azure / azure-init

A minimal provisioning agent designed for Azure Linux VMs.
MIT License
7 stars 10 forks source link

add Azure Linux support #87

Closed SeanDougherty closed 1 week ago

SeanDougherty commented 1 month ago

This PR adds support for Azure Linux to the 0.1.1 version of azure-init. I need to rebase to the current head of main, while I do this, I'm marking the PR as draft to facilitate discussion.

A notable delta between distros is the addition of the "wheel" and "sudo" groups and removal of the other groups in useradd.

Additionally, this PR adds the os-release crate to determine the OS azure-init is operating on during provisioning time.

Finally, Functional tests for AzureLinux are missing. An update of the functional test to support either Azure Linux OR Ubuntu is a goal. I'm happy to make this change to the functional test in this PR or in a separate PR at the maintainer's request.

t-lo commented 1 month ago

Hello @SeanDougherty 👋

Thank you for your work, great to see azure-init is useful for you! Just out of curiosity, could you please have a look at https://github.com/Azure/azure-init/pull/86 and check if that PR "magically" adds Azure-Linux support? We're trying to be distro-agnostic going forward, and it might well be Dongsu's PR will implicitly add support for Azure Linux (and a number of other distros, too).

If you need password authentication support for some reason (see Dongsu's question) I'm sure we'll find a way to work this into the generic approach.

SeanDougherty commented 1 week ago

Closing b/c PR is outdated. My new approach will be to work alongside maintainers within PR reviews and GH issues to bring Azure Linux support onboard 👍