Update AzureIoT Library with support for more boards

Azure / azure-iot-arduino

Azure IoT library for the Arduino

Other

168 stars 95 forks source link

Update AzureIoT Library with support for more boards #1

Closed stefangordon closed 8 years ago

stefangordon commented 8 years ago

Significant changes to support Adafruit Feather M0 Wifi and all ESP8266 boards. MKR1000 support will be verified as it is released.

This has the latest Azure SDK bits and a modified sync script. We are evaluating publishing SDK updates to this repo as part of our core SDK repo publishing process soon.

I'm a Microsoft engineer working with the Azure IoT Hub team to build out this library to support as many devices as possible. We are continuing to build out documentation and test on additional boards, but this has been tested on available SAMD and ESP8266 boards. I am happy to be collaborator on the core repository here and own testing and maintenance if appropriate as we have resources allocated to continue to improve this library.

This requires Arduino IDE 1.6.8.

Thanks!

sandeepmistry commented 8 years ago

@stefangordon @obsoleted great work on adding new board support!

I'm done with my comments for now, overall summary:

It would be great to reduce duplicate files for easier maintenance (HTTPSClient, NTPClient, the example sketches).
If possible, make SDK changes upstream, for things like `iot_logging.h``, in case that file is updated upstream and needs to be synced.

stefangordon commented 8 years ago

Thanks Sandeep! We'll incorporate most of these changes in the next day or so. The logging issue is challenging due to some unique issues with ESP8266, but we are working through getting it resolved through a redesign of logging in the SDK. I'll also file issues for work items and improvements we are still tracking.

stefangordon commented 8 years ago

Alright I think we are in decent shape here now. There will be continuous work/improvements over the next few weeks but this is stable enough to unblock people.

We have tested on ESP8266 boards (Huzzah and Sparkfun Thing) as well as Adafruit Feather M0 (SAMD). We were not able to do MKR1000 or Zero yet.

obsoleted commented 8 years ago

Thanks for the comments so far @sandeepmistry. I believe we have addressed them in the new commits. Do you have any other issues or concerns with accepting this?

sandeepmistry commented 8 years ago

@obsoleted I've added a few more review comments, but overall new changes look good.

obsoleted commented 8 years ago

@sandeepmistry Thanks for the comments. I've made some replies. And added the commit saving.

Again, we do hope to make continuous improvements to the library. Part of that will be getting this out there to start getting feedback on it.