search

Azure / azure-iot-arduino

Azure IoT library for the Arduino
Other
168 stars 95 forks source link

Fix travis test #45

Closed yuwzho closed 7 years ago

yuwzho commented 7 years ago

Refer this issue. Some linux system cannot recognize this backslah @mamokarz

msftclas commented 7 years ago

@yuwzho, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

yuwzho commented 7 years ago

I also make some changes for the .travis.yml, which install some necessary libraries and let the CI for ESP8266 work. But the samd boards still have some header not found

yuwzho commented 7 years ago

Fix the travis, the samd boards should use at least Arduino 1.6.11 IDE

tameraw commented 7 years ago

@yuwzho - We have fixed the slash for Linux in the version 1.0.30 as part of a separate check-in we had to do. We will review the other changes and get back to you.

yuwzho commented 7 years ago

@tameraw Thank you!

These pull request also includes install nessary libraries for Travis CI testing. Since some board definition updating, the new board package and old Arduino IDE are not compatiable. So I update the IDE version.

Also, the Serial.setDebugOutput(boolean); is a function for ESP8266, not for all boards.

yuwzho commented 7 years ago

Rebase the pullrequest and update the title

JetstreamRoySprowl commented 7 years ago

Hi Yuwei, we're about to do the merge and were wondering

  1. What is the motivation for only putting the Serial.setDebugOutput(true) call in for ESP8266? A comment might be good here.
  2. Line 24 of the .yml shows a redundant call to install the WiFi101 library. If there is a reason this needs to happen twice then a comment would definitely be useful.
JetstreamRoySprowl commented 7 years ago

We've accepted the pull request and it will be merged into the next release.