search

Azure / azure-iot-arduino

Azure IoT library for the Arduino
Other
168 stars 95 forks source link

Azureiothubclient remove #53

Closed GregTerrell closed 7 years ago

GregTerrell commented 7 years ago

Removed AzureIoTHubClient.cpp (.h);

Updated example (http) by removing AzureIoTHubClient references in .ino: instantiation of iotHubClient object, iotHubClient.begin() in setup() and iotHubClient.setEpochTime() in initTime()

This is my 1st pull request, hope I did it correctly mamokarz. I will wait for results before doing pull-requests for the other 3 project examples (http, mqtt, utility). Thanks: GT

msftclas commented 7 years ago

@GregTerrell, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects. Thanks, Microsoft Pull Request Bot

msftclas commented 7 years ago

@GregTerrell, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

BertKleewein commented 7 years ago

Hi @GregTerrell, I'll be getting this code checked in, but the process is slightly more involved than accepting a pull request -- it has to go into a different repo and then get moved over here via some method that I'm just learning about. Don't worry, I'll do all the work and I'll keep you informed of my progress.

GregTerrell commented 7 years ago

I don't think there is a need to keep epochTime, I guess I assumed the IotHub client was referencing the device time somewhere further in the initialization. We would keep it for some cases, but that is application code issue not library.

GregTerrell commented 7 years ago

I thought I deleted that line, sorry that should go. I am still working our my github workflows.

BertKleewein commented 7 years ago

Code was manually merged. I did this by copying to this change to https://github.com/Azure/azure-iot-sdk-c and then using our build scripts to propagate the changes back to this repo.

GregTerrell commented 7 years ago

Thanks, there is the same issue ( iotHubClient ) in the http, mqtt, and utility repos (they all have a simpleSample example). Would you like me to do (attempt... still learning) a pull-request to facilitate getting those in-sync?

I know when I see conflicting structures in examples I am often left confused on which is correct.

BertKleewein commented 7 years ago

Don't be worried, these are unusual projects and they don't follow the usual rules or processes. I think pull requests might be the best way right now.

Thanks for keeping an eye on consistency. It really does make a difference.

From: Bert Kleewein bertk@microsoft.com<mailto:bertk@microsoft.com> Sent: Saturday, June 3, 2017 7:48 AM Subject: Re: [Azure/azure-iot-arduino] Azureiothubclient remove (#53) To: Azure/azure-iot-arduino reply@reply.github.com<mailto:reply@reply.github.com>, Azure/azure-iot-arduino azure-iot-arduino@noreply.github.com<mailto:azure-iot-arduino@noreply.github.com> Cc: State change state_change@noreply.github.com<mailto:state_change@noreply.github.com>

From: Greg Terrell notifications@github.com<mailto:notifications@github.com> Sent: Saturday, June 3, 2017 4:09 AM Subject: Re: [Azure/azure-iot-arduino] Azureiothubclient remove (#53) To: Azure/azure-iot-arduino azure-iot-arduino@noreply.github.com<mailto:azure-iot-arduino@noreply.github.com> Cc: Bert Kleewein bertk@microsoft.com<mailto:bertk@microsoft.com>, State change state_change@noreply.github.com<mailto:state_change@noreply.github.com>

Thanks, there is the same issue ( iotHubClient ) in the http, mqtt, and utility repos (they all have a simpleSample example). Would you like me to do (attempt... still learning) a pull-request to facilitate getting those in-sync?

I know when I see conflicting structures in examples I am often left confused on which is correct.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-iot-arduino%2Fpull%2F53%23issuecomment-305968264&data=02%7C01%7Cbertk%40microsoft.com%7Ca0bda3c0b496482cec8008d4aa70fa13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636320849589079608&sdata=bj3byUERItJswOwwZhJNg3XfIf4CR8v4pKfEXh6AHps%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHqCQgXYsjxPOlwQljWM-Rx54faiUJjpks5sAT7cgaJpZM4NdDSW&data=02%7C01%7Cbertk%40microsoft.com%7Ca0bda3c0b496482cec8008d4aa70fa13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636320849589079608&sdata=bjlCCN5dFkKjaddfUv4NQ5eZYhBu3UQjHhI4244U%2Fxw%3D&reserved=0.