Closed vilit1 closed 2 years ago
Top test run is when dps name is specified (and has the correct DPS data Contributor role) Bottom run is when dps name is not specified so the dps is generated
@vilit1 - Looks good to me (minus the few nit comments about history), @digimaun would you mind giving the RBAC auth parameter / token generation for DPS a quick once-over since you scaffolded the original IoT Hub scenarios? Looks like we switched to using a separate DPS and Hub auth-type (which I think is the right move) - just making sure I didn't miss anything that might cause issues there.
DPS IT:
IOT hub
Update to generated sdk. The operations got generated as a group of files rather than one single file with all the commands. DPS.py was updated to reflect that.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).