Azure / azure-iot-cli-extension

Azure IoT extension for Azure CLI
Other
83 stars 65 forks source link

DPS SDK update + RBAC support #471

Closed vilit1 closed 2 years ago

vilit1 commented 2 years ago

Update to generated sdk. The operations got generated as a group of files rather than one single file with all the commands. DPS.py was updated to reflect that.

image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

Basic expectations

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

vilit1 commented 2 years ago

image Top test run is when dps name is specified (and has the correct DPS data Contributor role) Bottom run is when dps name is not specified so the dps is generated

c-ryan-k commented 2 years ago

@vilit1 - Looks good to me (minus the few nit comments about history), @digimaun would you mind giving the RBAC auth parameter / token generation for DPS a quick once-over since you scaffolded the original IoT Hub scenarios? Looks like we switched to using a separate DPS and Hub auth-type (which I think is the right move) - just making sure I didn't miss anything that might cause issues there.

vilit1 commented 2 years ago

image

vilit1 commented 2 years ago

image

vilit1 commented 2 years ago

DPS IT: image

vilit1 commented 2 years ago

IOT hub image