Azure / azure-iot-cli-extension

Azure IoT extension for Azure CLI
Other
83 stars 66 forks source link

ADT Bulk Import #517

Closed avagraw closed 2 years ago

avagraw commented 2 years ago

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

Basic expectations

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

digimaun commented 2 years ago

Please make a HISTORY.rst entry describing this change.

digimaun commented 2 years ago

Is this functionality able to be released or does it need to wait?

avagraw commented 2 years ago

Please make a HISTORY.rst entry describing this change.

Sure

Is this functionality able to be released or does it need to wait?

Yes, Shipra has confirmed that the functionality should be released specifying that the commands are in preview (hence I have added the is_preview tag)

digimaun commented 2 years ago

Please make a HISTORY.rst entry describing this change.

Sure

Is this functionality able to be released or does it need to wait?

Yes, Shipra has confirmed that the functionality should be released specifying that the commands are in preview (hence I have added the is_preview tag)

OK. Let's please see a test run.

avagraw commented 2 years ago

Please make a HISTORY.rst entry describing this change.

Sure

Is this functionality able to be released or does it need to wait?

Yes, Shipra has confirmed that the functionality should be released specifying that the commands are in preview (hence I have added the is_preview tag)

OK. Let's please see a test run.

Yeah working on that

avagraw commented 2 years ago

Test run: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=5842&view=logs&j=e24f7e52-36f4-54e9-a8eb-6f10b62b4c84&t=85779272-bb12-5d7f-5c2e-f38ba3ce51f9 - The test test_dt_importjobs passes. Data history tests are failing because of some capacity issue - but they are out of scope for this PR