Closed vilit1 closed 1 year ago
Please post the pipeline run showing the testing evidence.
@digimaun Since, this is a temporary change, should we update history?
Please add an entry to HISTORY.rst
under 0.17.1
and we can increment the version of the extension in this PR to 0.17.1
https://github.com/Azure/azure-iot-cli-extension/blob/dev/azext_iot/constants.py#L10
Durations with a pre-created IoT Hub with the correct feature enabled:
Please post the pipeline run showing the testing evidence.
@digimaun Since, this is a temporary change, should we update history?
I would still because its user facing, even if temporary, in fact our release notes can use some kind of "limited period availability" nomenclature.
Added a fix for the initial root authority change
tests passing (local run, on a different sub, still in canary env):
Note that for these tests, I modified the tests so that:
LGTM pending bash feedback, and successful IT run. +We discussed RBAC simplification strategies for tests offline.
Migrate the Certificate CA for IoT Hub from Baltimore to DigiCert.
Commands introduced:
Show has a default, since the service will return {} or None for that property. Set checks if the version chosen is already set before migration.
Note that this is a temporary command, will be removed after every hub has been migrated.
Note that this command will work only for some subscriptions and resource managers in the current state. Will update the pr as the feature becomes more avaliable.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).