Azure / azure-iot-cli-extension

Azure IoT extension for Azure CLI
Other
83 stars 66 forks source link

Pipeline updates - Add reference doc validation and fix warnings #552

Closed c-ryan-k closed 2 years ago

c-ryan-k commented 2 years ago

Currently the reference document validation job is only used in the merge pipeline, but we could easily add this to the build stage of the release (or nightly) pipelines as well.


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

Basic expectations

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

c-ryan-k commented 2 years ago

Test run - https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6189&view=results

digimaun commented 2 years ago

LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146

c-ryan-k commented 2 years ago

LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146

Added that commit and tested: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6198&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e&j=3e99c488-073e-58ad-3836-9f05f03bc0ca

digimaun commented 2 years ago

LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146

Added that commit and tested: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6198&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e&j=3e99c488-073e-58ad-3836-9f05f03bc0ca

Thank you, :shipit: Ship it