Closed c-ryan-k closed 2 years ago
LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146
LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146
Added that commit and tested: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6198&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e&j=3e99c488-073e-58ad-3836-9f05f03bc0ca
LGTM - we should also add this as a step to the create release pipeline as we do with the command table linter https://github.com/Azure/azure-iot-cli-extension/blob/dev/.azure-devops/create-release.yml#L146
Added that commit and tested: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6198&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e&j=3e99c488-073e-58ad-3836-9f05f03bc0ca
Thank you, :shipit: Ship it
.x
from python version arguments to fix warnings in pipelines10.15
to11
as 10.15 is now deprecatedCurrently the reference document validation job is only used in the merge pipeline, but we could easily add this to the build stage of the release (or nightly) pipelines as well.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).