Closed vilit1 closed 1 year ago
local Test runs: if cosmos db is not created:
if cosmos db is created before tests:
currently tests pass locally
local hub test pass
There is a stacktrace when attempting to create a message-endpoint
There is a stacktrace when attempting to create a message-endpoint
temporary fix is to do pip install -U azure-mgmt-iothub
/azp run
test run: The job with messaging endpoints isnt failing but the other job is timing out so far: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7128&view=results
going to look into this more
/azp run
nightly passing: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7152&view=results the min cli version does not support the cosmos db yet so that test is skipped
/azp run
~Waiting for merge - need to have the newer SDK with the Cosmos DB feature released due to non-backwards compatible API.~
Edit: since 10/25, it seems like this is no longer the case and the api is now backwards compatible. Testing shows that it should be more or less satisfactory aside from being able to create and test routes with the cosmos db endpoint but not show/list/update/delete them. Service is dealing with that.
Edit: 11/1, we will go back to waiting on the Azure CLI core to have the new sdk so we don't have the extension fight with the core for sdk versions.
Addition of Cosmos DB Endpoint creation!
Essentially moving over endpoint and route management right now. The new command groups are:
Sadly the sdk used still has models (endpoints's UserAssignedIdentities property does not work well with modelless)
Endpoints creation is broken up, like so:
This helps isolate which params are needed for which specific endpoints.
Other quality of life fixes:
route test
app-properties and system-properties to correctly try to change the format of those arguments to json before sending it to the service *Notes: * these will be fixed in the azure cli core commands too.
Also added a small fix in the dynamosettings, if the value is "sentinel" then it is nulled out. This value gets set if there is misconfigured pipeline variable (especially if adding new pipeline variables).
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).