Azure / azure-iot-cli-extension

Azure IoT extension for Azure CLI
Other
83 stars 65 forks source link

Hub endpoint control plane #556

Closed vilit1 closed 1 year ago

vilit1 commented 2 years ago

~Waiting for merge - need to have the newer SDK with the Cosmos DB feature released due to non-backwards compatible API.~

Edit: since 10/25, it seems like this is no longer the case and the api is now backwards compatible. Testing shows that it should be more or less satisfactory aside from being able to create and test routes with the cosmos db endpoint but not show/list/update/delete them. Service is dealing with that.

Edit: 11/1, we will go back to waiting on the Azure CLI core to have the new sdk so we don't have the extension fight with the core for sdk versions.

Addition of Cosmos DB Endpoint creation!

Essentially moving over endpoint and route management right now. The new command groups are:

Sadly the sdk used still has models (endpoints's UserAssignedIdentities property does not work well with modelless)

Endpoints creation is broken up, like so:

This helps isolate which params are needed for which specific endpoints.

Other quality of life fixes:

Notes: * these will be fixed in the azure cli core commands too.

Also added a small fix in the dynamosettings, if the value is "sentinel" then it is nulled out. This value gets set if there is misconfigured pipeline variable (especially if adding new pipeline variables).


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

Basic expectations

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

vilit1 commented 2 years ago

local Test runs: if cosmos db is not created: image

if cosmos db is created before tests: image

vilit1 commented 2 years ago

image currently tests pass locally

vilit1 commented 1 year ago

local hub test pass image

vilit1 commented 1 year ago

https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=6855&view=results

digimaun commented 1 year ago

There is a stacktrace when attempting to create a message-endpoint

image image

vilit1 commented 1 year ago

There is a stacktrace when attempting to create a message-endpoint

image image

temporary fix is to do pip install -U azure-mgmt-iothub

c-ryan-k commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
vilit1 commented 1 year ago

test run: The job with messaging endpoints isnt failing but the other job is timing out so far: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7128&view=results

going to look into this more

vilit1 commented 1 year ago

https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7138&view=results

vilit1 commented 1 year ago

better test run https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7145&view=results

vilit1 commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
vilit1 commented 1 year ago

nightly passing: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7152&view=results the min cli version does not support the cosmos db yet so that test is skipped

vilit1 commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).