Closed c-ryan-k closed 1 year ago
pipeline run?
pipeline run?
Merge was completed in this PR, waiting for some other pipelines to finish before I kick off dry-runs of the nightly and release pipelines to ensure we're good on 20.04 at least.
May do some testing today or tomorrow to try out 22.04, but think this is safe to include as a runtime option since it isn't a default value.
Lets get this in soon
Lets get this in soon
Trying to pin down a test failure in ADT while running this merge branch against our current release pipeline. Not sure if it's at all related to the jump from 18 to 20, but want to verify and see the ADT tests pass on 20 before moving forward.
If necessary, I can also modify this PR to still set the default to 20.04, but leave 18.04 as an option for break-glass scenarios if we need a release and 20 is failing for some reason.
We've started getting warnings as ubuntu-18.04 images are deprecated on ADO.
This update pushes our ubuntu images up to 20.04 (which is also the same as ubuntu-latest currently), but also provides support for testing pipelines on ubuntu 22.04
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).