Azure / azure-iot-cli-extension

Azure IoT extension for Azure CLI
Other
82 stars 65 forks source link

Remove client validation for loading certificate #607

Closed Elsie4ever closed 1 year ago

Elsie4ever commented 1 year ago

This pr is the second part of addressing the enrollment group create/update with certificate issue. I removed the validation on the client side to make sure we are not over validating the certificate content, so that way the certificate validation now is fully handled by service call. The file extension check is removed and I kept the help text in place to give user more guidance on the certificate format


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

Basic expectations

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

Elsie4ever commented 1 year ago

image

vilit1 commented 1 year ago

Add a history for the changes you did (specifically the fact that certificate files are no longer restricted by file extension)

Elsie4ever commented 1 year ago

@vilit1 history updated, please feel free to take another look, thanks!