Add max-models-per-batch parameter to dt models creation and fix test

Elsie4ever commented 1 year ago

Upon investigation, the model create from directory was failing across multiple version of ubuntu and can be obeserved from multiple pipeline build, and reducing the max-models-per-batch default to 30 fix the issue(it will then take more time to make sure models are pull in right order) therefore to prevent the user from ubuntu encounter error when dt service is flaky in the future, adding this as a parameter that default to 30. Also added this value to environment variable so we can adjust it from pipeline if this issue happen again. Pipeline build: Ubuntu 18.04: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7884&view=results Ubuntu 20.04: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7831&view=results Ubuntu 22.04: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7833&view=results

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

[ ] It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

[ ] If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
[ ] In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
[ ] Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
[ ] Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
[ ] Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
[ ] Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

vilit1 commented 1 year ago

Undo temp and then I will merge. It seems like something is off with dt endpoint create so I will investigate in a future pr to see if it is a service issue or something we need to fix

Elsie4ever commented 1 year ago

new pipeline build https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7909&view=results

digimaun commented 1 year ago

Why is this PR being used to apply feedback from an unrelated PR? A new PR can be made with follow ups.

Elsie4ever commented 1 year ago

Why is this PR being used to apply feedback from an unrelated PR? A new PR can be made with follow ups.

sorry, will create a new one😋

Elsie4ever commented 1 year ago

Pipeline run succeeded https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=7917&view=results

Azure / azure-iot-cli-extension

Add max-models-per-batch parameter to dt models creation and fix test #638

General Guidelines