Closed vilit1 closed 1 year ago
The PR looks good to me, just got 2 questions mentioned above, thanks a lot!😀
I found this test_dps_device_registration_unlinked_hub test has been failed consistently in ubuntu 20.04 https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8226&view=logs&j=1e6b4794-1f9a-54f4-f473-41f4c9a18170&t=32f52c1e-fa8e-5ce8-5853-9481f10d33c0 https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8219&view=logs&j=1e6b4794-1f9a-54f4-f473-41f4c9a18170&t=32f52c1e-fa8e-5ce8-5853-9481f10d33c0
I found this test_dps_device_registration_unlinked_hub test has been failed consistently in ubuntu 20.04 https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8226&view=logs&j=1e6b4794-1f9a-54f4-f473-41f4c9a18170&t=32f52c1e-fa8e-5ce8-5853-9481f10d33c0 https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8219&view=logs&j=1e6b4794-1f9a-54f4-f473-41f4c9a18170&t=32f52c1e-fa8e-5ce8-5853-9481f10d33c0
The annoying part is that these errors are transient and from the runs here, happen if:
I will investigate more on if I can make them less transient
https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8290&view=results tests no longer rerun constantly
Main goal of this is to remove the janky dps script in the pipeline.
Example run with no preset dps: Note that only one hub is created (and deleted).
Example run with preset dps in pytest.ini: will pass with preset dps
Pipeline run: https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8013&view=results
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).