Closed vilit1 closed 1 year ago
https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=8584&view=logs&j=b965e18a-779e-5a51-69f7-83f4f4e9bf18&t=2484dd94-e2e0-5f09-9779-c7fe64edb6e9 things look good - issues with dps are dps being flaky and hub is just hub broke for some reason
Original pr: https://github.com/Azure/azure-iot-cli-extension/pull/646
The new method for the catch stderr:
Changed some tests to reflect the errors raised - tests now look for more specific errors rather than failure. Also added some error handling to message endpoint and route
Only some tests are using the new functionality.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).