Azure / azure-iot-explorer

Cross-platform UI for interacting with devices attached to Azure IoT Hub. This tool is meant for learning and testing, not for production environment.
MIT License
223 stars 72 forks source link

Telemetry for page views - count and visit time #513

Closed shahm5 closed 2 years ago

shahm5 commented 2 years ago

Added Azure App Insights logging to keep track of page views and page view times

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the Azure IoT Explorer!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

YingXue commented 2 years ago

This does not seem to be right fix for test, as now we have duplicates in app.config and app.*.config. We have two things to do here:

  1. I assume that we have verified manually that using app.*.config before this commit does make things functional, the app is choosing the right string respectively
  2. Look into how Jest can mock up the config values to get rid of the errors.

No worries on the dups of the reply. All you would need to do is, simply write appConfig.telemetryConnString = 'someteststring' in all the tests where it's saying 'missing instrument key'. That's my understanding, please check if that works, and revert the last change.