search

Azure / azure-iot-operations

The official repo for Azure IoT Operations.
MIT License
20 stars 16 forks source link

Hardcoded Azure subscription id in grafana dashboards #45

Open bindsi opened 2 months ago

bindsi commented 2 months ago

the subscriptionIds are hard-coded in multiple grafana dashboard json files

"resources": [
              "/subscriptions/af342bf1-1ace-41df-902c-47921400551b"
            ],

add a place holder and a small script that can use sed command to replace the placeholder with the right subscriptionId of the target tenant.

meenag16 commented 2 months ago

Hi, do you mind clarifying what the ask here is?

bindsi commented 2 months ago

yeah, sure...you should remove that internal subscriptionId from the sample and add a placeholder that can be replace by sed -i "s/##subscriptionId##/<newSubscriptionId>/g" dashboardxxx.jsoncommand or at least refer to it in the guidelines please!

larrylieberman commented 2 months ago

@meenag16 to clarify further: @bindsi is pointing out that (1) there are currently some grafana dashboards in this very AIO repo that (2) currently have an embedded subscriptionid that should be removed. This in this repo at https://github.com/Azure/azure-iot-operations/tree/main/tools/setup-3p-obs-infra, and referred to from the official documentation at https://learn.microsoft.com/en-us/azure/iot-operations/monitor/howto-configure-observability#install-observability-components.