Update broker check to 0.7.0 according to the change list:
Broker
Status structure update
BrokerListnener
brokerRef has been removed
ports[].tls.automatic renamed to ports[].tls.certManagerCertificateSpec
ports[].tls.certManagerCertificateSpec.issuerRef.apiGroup renamed to ports[].tls.certManagerCertificateSpec.issuerRef.group
Add a helper function to evaluate new status, since it might be similar across services
in detail 0 it shows an overall status with worst case calculation:
in detail 1 it shows both runtime and provision status if both exist
detail 2
add tls check in broker listener, refactored the one of condition check to base so it can be used across service
Add unit tests for resource.py
TODO: will add BrokerAuthorization and BrokerAuthentication evaluations in next pr
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
[ ] It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.
Basic expectations
[ ] If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
[ ] In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
[ ] Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
[ ] Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
[ ] Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
[ ] Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?
Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).
Update broker check to 0.7.0 according to the change list:
Broker Status structure update
BrokerListnener brokerRef has been removed ports[].tls.automatic renamed to ports[].tls.certManagerCertificateSpec ports[].tls.certManagerCertificateSpec.issuerRef.apiGroup renamed to ports[].tls.certManagerCertificateSpec.issuerRef.group
in detail 1 it shows both runtime and provision status if both exist
detail 2
TODO: will add BrokerAuthorization and BrokerAuthentication evaluations in next pr
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
devormainare of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrcand.flake8rules? Look at the CI scripts for example usage.Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).