search

Azure / azure-iot-remote-monitoring

Azure IoT Remote Monitoring preconfigured solution
Other
249 stars 221 forks source link

Restrict DocDB names to 24 chars #407

Closed vishwam closed 7 years ago

vishwam commented 7 years ago

DocDB’s documentation says it allows 3-50 chars, but their actual length limit varies per-region (bug 846765). Restrict to 24 chars based on their dev’s recommendation.

azurecla commented 7 years ago

Hi @vishwam, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (vishwams). If you're full-time, we DON'T require a contribution license agreement. 

<p>
    If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.
</p>

TTYL, AZPRBOT;

joyhui commented 7 years ago

@vishwam Can you put a comment to the line you fixed? So that we know the reason why we have this 19 in code. BTW, you mentioned 24 chars is recommended by their dev, why 19 comes out in the coe?

vishwam commented 7 years ago

@joyhui I've added the comment

joyhui commented 7 years ago

Thanks!