Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
587 stars 740 forks source link

CMake compatibility warning due to azure-macro-utils-c and umock-c requiring deprecated CMake version. #2464

Closed ryanwinter closed 1 year ago

ryanwinter commented 1 year ago

Development Machine, OS, Compiler (and Other Relevant Toolchain Info)

Windows 11 with Visual Studio 2022 CMake version cmake version 3.25.1-msvc1

SDK Version (Please Give Commit SHA if Manually Compiling)

Commit hash 89db361d241766558b11a142b487228dfc070748

Protocol

None - cmake generation warning

Describe the Bug

When executing the following command cmake -Bcmake -Duse_prov_client=ON -Dhsm_type_symm_key=ON -Drun_e2e_tests=OFF

I see cmake deprecation warnings regarding azure-macro-utils-c and umock-c.

MCVE

git clone https://github.com/Azure/azure-iot-sdk-c.git
cd azure-iot-sdk-c
git submodule update --init
cmake -Bcmake -Duse_prov_client=ON -Dhsm_type_symm_key=ON -Drun_e2e_tests=OFF

Console Logs

CMake Deprecation Warning at deps/azure-macro-utils-c/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at deps/umock-c/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
ericwolz commented 1 year ago

Yes, this is a know issue. These are only warnings and CMake still functions correctly. Currently there are no plans to update these dependent repos.