Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
587 stars 739 forks source link

Install iothub_client internal headers ALSO under azureiot/internal #2507

Closed ewertons closed 1 year ago

ewertons commented 1 year ago
# Checklist - [x] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md). - [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down). - If this is a modification that impacts the behavior of a public API - [ ] I edited the corresponding document in the `devdoc` folder and added or modified requirements. - I submitted this PR against the correct branch: - [x] This pull-request is submitted against the `main` branch. - [x] I have merged the latest `main` branch prior to submission and re-merged as needed after I took any feedback. - [x] I have squashed my changes into one with a clear description of the change. # Reference/Link to the issue solved with this PR (if any) # Description of the problem

ARM and MIPS32 crosscompilation builds are failing due to changes in upload-to-blob header includes throughout azure-iot-sdk-c.

Description of the solution

- Install iothub_client internal headers ALSO under "azureiot/internal", since many #include use the "internal" relative path. - Add "include/azureiot" to include_directories of ARM and MIPS32 toolchains, since that's where the headers is installed by default. Note: These tasks (cross-comp of ARM and MIPS32) apparently ran when the PR for upload to blob changes was validated for merging, but they test against main in https://github.com/azure/azure-iot-sdk-c, not against the PR code itself.
ewertons commented 1 year ago

This PR will be reworked.