Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
588 stars 739 forks source link

Fix incorrect internal header include introduced by upload-to-blob refactoring #2510

Closed ewertons closed 1 year ago

ewertons commented 1 year ago
# Checklist - [x] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md). - [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down). - If this is a modification that impacts the behavior of a public API - [ ] I edited the corresponding document in the `devdoc` folder and added or modified requirements. - I submitted this PR against the correct branch: - [x] This pull-request is submitted against the `main` branch. - [x] I have merged the latest `main` branch prior to submission and re-merged as needed after I took any feedback. - [x] I have squashed my changes into one with a clear description of the change. # Reference/Link to the issue solved with this PR (if any) # Description of the problem

Internal headers must not be referenced by any public header. The recent u2b changes caused iothub_client_core_ll.h to include internal/iothub_client_ll_uploadtoblob.h, which is incorrect.

Description of the solution

This fix removes this include directive from iothub_client_core_ll.h and moves the type IOTHUB_CLIENT_LL_UPLOADTOBLOB_HANDLE into iothub_client_core_common.h, solving the need for both client layer and upload-to-blob modules to reference this type.